Remove WORKAROUND_ISSUE_622 #3974
Conversation
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
We no longer test slirp4netns port forwarder, but we still test the slirp4netns network driver, which is allegedly related to #622 |
|
Didn't you say it would only happen with rootlesskit v1? |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - ubuntu: 22.04 | ||
| containerd: v1.7.25 | ||
| containerd: v1.6.36 | ||
| rootlesskit: v1.1.1 # Deprecated |
There was a problem hiding this comment.
We still have RootlessKit v1 here, so the workaround still has to be enabled for this
There was a problem hiding this comment.
We do have rootlesskit v1, but we do not test slirp with it.
The only target we are testing slirp for is https://github.com/containerd/nerdctl/pull/3974/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88R242-R246
There was a problem hiding this comment.
There are two kinds of the slirp4netns drivers:
- network driver: outgoing connections
- port driver: incoming connections
The code here still uses slirp4netns as the network driver
There was a problem hiding this comment.
My bad.
Thanks for clarifying!
There was a problem hiding this comment.
Kind of curious to see it fail though. Can we leave this PR open long enough for the full CI run?
Then I'll close it.
|
project-checks breakage is unrelated (I guess Phil just broke it :D) |
No, I broke it 🙇 Being fixed in: |
On top of #3973
We no longer test rootlesskit v1 + slirp4netns (actually, we haven't for a while), so this hack is presumably no longer necessary.