Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix required kunalkushwaha error #2004

Merged
merged 1 commit into from
Mar 7, 2025
Merged

fix required kunalkushwaha error #2004

merged 1 commit into from
Mar 7, 2025

Conversation

wswsmao
Copy link
Contributor

@wswsmao wswsmao commented Mar 5, 2025 •
edited
Loading

update project-checks to v1.2.2 to fix this error in CI, It seems to be the same issue as containerd/nerdctl#3976,
cc @AkihiroSuda

  • before updating to v1.2.2
  github.com/hashicorp/go-version
  github.com/sirupsen/logrus
  github.com/vbatts/git-validation/git
  github.com/vbatts/git-validation/validate
  github.com/vbatts/git-validation/rules/danglingwhitespace
  github.com/vbatts/git-validation/rules/dco
  github.com/vbatts/git-validation/rules/shortsubject
  github.com/vbatts/git-validation/rules/messageregexp
  github.com/vbatts/git-validation
  go: downloading github.com/kunalkushwaha/ltag v0.3.0
  go: github.com/kunalkushwaha/ltag@latest: version constraints conflict:
  	github.com/kunalkushwaha/[email protected]: parsing go.mod:
  	module declares its path as: github.com/containerd/ltag
  	        but was required as: github.com/kunalkushwaha/ltag
  Error: Process completed with exit code 1.
  • after updating to v1.2.2 and not go-licenses-ignore
Not allowed license  found for library github.com/containerd/stargz-snapshotter/estargz
Not allowed license  found for library github.com/containerd/stargz-snapshotter/estargz/errorutil
Not allowed license  found for library github.com/containerd/stargz-snapshotter/estargz/externaltoc
Not allowed license  found for library github.com/containerd/stargz-snapshotter/estargz/zstdchunked
Not allowed license MPL-2.0 found for library github.com/hashicorp/go-cleanhttp
Not allowed license MPL-2.0 found for library github.com/hashicorp/go-retryablehttp

AkihiroSuda
AkihiroSuda reviewed Mar 6, 2025
View reviewed changes
.github/workflows/tests.yml
with:
working-directory: src/github.com/containerd/stargz-snapshotter
go-licenses-ignore: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after updating to v1.2.2 and not go-licenses-ignore will report error :

Not allowed license  found for library github.com/containerd/stargz-snapshotter/estargz
Not allowed license  found for library github.com/containerd/stargz-snapshotter/estargz/errorutil
Not allowed license  found for library github.com/containerd/stargz-snapshotter/estargz/externaltoc
Not allowed license  found for library github.com/containerd/stargz-snapshotter/estargz/zstdchunked
Not allowed license MPL-2.0 found for library github.com/hashicorp/go-cleanhttp
Not allowed license MPL-2.0 found for library github.com/hashicorp/go-retryablehttp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like this
#2001

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add reasons why these errors can be safely ignored

Copy link
Contributor Author

@wswsmao wswsmao Mar 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two packages listed below are licensed under MPL-2.0, which is not included in the allowed-third-party-license-policy.md. Shall we directly use go-licenses-ignore to suppress the related license warnings?

github.com/hashicorp/go-cleanhttp
github.com/hashicorp/go-retryablehttp

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link https://github.com/cncf/foundation/blob/main/license-exceptions/CNCF-licensing-exceptions.csv in the YAML to clarify that these packages are exceptionally allowed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@wswsmao
Copy link
Contributor Author

wswsmao commented Mar 6, 2025

re-push to refresh CI

@wswsmao wswsmao closed this Mar 6, 2025
@wswsmao wswsmao reopened this Mar 6, 2025
@wswsmao
Copy link
Contributor Author

wswsmao commented Mar 7, 2025

all done @AkihiroSuda

AkihiroSuda
AkihiroSuda approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 930e944 into containerd:main Mar 7, 2025
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wswsmao @AkihiroSuda