Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few misc prep patches #1108

Merged
merged 4 commits into from
Feb 12, 2025
Merged

A few misc prep patches #1108

merged 4 commits into from
Feb 12, 2025

Conversation

cgwalters
Copy link
Collaborator

utils: Fix compliation standalone

We use tokio::test so need the macros feature.

Signed-off-by: Colin Walters [email protected]


utils: Add a method to split an iterator

Signed-off-by: Colin Walters [email protected]


provision-derived: Clean lots more stuff

Yeah, we're going to need a dnf clean all --everything...

Signed-off-by: Colin Walters [email protected]


Update cap-std-ext, use new open_dir_noxdev API

I moved the code there; I plan to use open_dir_noxdev in
the tmpfiles code too which can't depend on lib/util.

Signed-off-by: Colin Walters [email protected]


We use `tokio::test` so need the macros feature.

Signed-off-by: Colin Walters <[email protected]>
Yeah, we're going to need a `dnf clean all --everything`...

Signed-off-by: Colin Walters <[email protected]>
I moved the code there; I plan to use open_dir_noxdev in
the tmpfiles code too which can't depend on lib/util.

Signed-off-by: Colin Walters <[email protected]>
@github-actions github-actions bot added the area/install Issues related to `bootc install` label Feb 12, 2025
@jeckersb jeckersb self-assigned this Feb 12, 2025
Copy link
Contributor

@jeckersb jeckersb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

}

#[cfg(test)]
mod tests {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@jeckersb jeckersb enabled auto-merge February 12, 2025 16:54
@cgwalters
Copy link
Collaborator Author

Merging over red because these basically can't¹ break the e2es and it will avoid a retest cycle

¹ I mean...I'd be amazed

@cgwalters cgwalters disabled auto-merge February 12, 2025 20:01
@cgwalters cgwalters merged commit c34b5e5 into containers:main Feb 12, 2025
18 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to `bootc install`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants