Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/pushpull: Work around podman/skopeo interaction bug #1109

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

cgwalters
Copy link
Collaborator

See #1101 (comment) Basically things break unless "podman" initializes the c/storage instance right now.

Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

See containers#1101 (comment)
Basically things break unless "podman" initializes the c/storage instance right now.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters
Copy link
Collaborator Author

Ah ok there were two different tests whose first invocation was bootc image copy-to-storage...hmmm...actually, it's tempting to work around this in bootc instead of in our tests

@cgwalters
Copy link
Collaborator Author

Cool this works. Looks like copr/s390x is out to lunch though.

@cgwalters cgwalters merged commit 8decbcd into containers:main Feb 12, 2025
20 of 23 checks passed
@cgwalters
Copy link
Collaborator Author

Ah ok there were two different tests whose first invocation was bootc image copy-to-storage...hmmm...actually, it's tempting to work around this in bootc instead of in our tests

Yeah I thought about this more and I think we should indeed work around this directly in bootc so I did #1110 which reverts this change to the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants