Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Explore with Reader TryInto Value and JSON formatting #911

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gpeacock
Copy link
Collaborator

@gpeacock gpeacock commented Feb 7, 2025

This adds a TryInto serde_json::Value method for Reader.

It also has a demo unit test that reformats the JSON output assertions. I'm not sure if that function belongs in the Reader or not.

This is not ready to merge, but I'm doing a PR for easy comparision.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 90.69767% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.83%. Comparing base (4cb20e3) to head (5d7f8b8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/reader.rs 90.69% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
- Coverage   78.97%   78.83%   -0.15%     
==========================================
  Files         146      146              
  Lines       34555    34732     +177     
==========================================
+ Hits        27291    27381      +90     
- Misses       7264     7351      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scouten-adobe scouten-adobe changed the title feat: explore with Reader TryInto Value and json formatting. feat: Explore with Reader TryInto Value and JSON formatting Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant