DRAFT: Add StatusTracker to IdentityAssertion parsing and validation APIs
#943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmathern
reviewed
Feb 25, 2025
scouten-adobe
force-pushed
the
cawg-validate+status-tracker
branch
from
37cded3 to
4b4806c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
==========================================
+ Coverage 78.80% 78.87% +0.06%
==========================================
Files 146 146
Lines 35096 35188 +92
==========================================
+ Hits 27656 27753 +97
+ Misses 7440 7435 -5 ☔ View full report in Codecov by Sentry. |
scouten-adobe
force-pushed
the
cawg-validate+status-tracker
branch
from
4b4806c to
ef95c5f
Compare
scouten-adobe
commented
Feb 27, 2025
| .map(|a| (a.label().to_owned(), a.to_assertion())) | ||
| .inspect(|(label, r)| { | ||
| if let Err(err) = r { | ||
| // TO DO: a.label() is probably wrong (not a full JUMBF URI) |
There was a problem hiding this comment.
@gpeacock is there a way I can get from Manifest.assertions() iterator to the JUMBF URI for the assertion returned?
scouten-adobe
commented
Feb 27, 2025
# Conflicts: # cawg_identity/src/tests/builder/simple_case.rs # cawg_identity/src/tests/x509.rs
…claim V2's assertions list
scouten-adobe
force-pushed
the
cawg-validate+status-tracker
branch
from
9f20a08 to
5dcfaa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.