Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests with nette/component-model 3.1.0 #91

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Fix tests with nette/component-model 3.1.0 #91

merged 1 commit into from
Feb 19, 2024

Conversation

jtojnar
Copy link
Collaborator

@jtojnar jtojnar commented Feb 17, 2024

Container::getComponents() returns array when $deep is false:
nette/component-model@7f613ee

@jtojnar
Copy link
Collaborator Author

jtojnar commented Feb 17, 2024

There is still breakage from nette/application@bb8f93c in webchemistry/testing-helpers. It can be fixed with the following patch but there are other issues with it and the repo looks dead so not sure if it makes sense trying to track them down:

--- a/src/Components/Presenter.php
+++ b/src/Components/Presenter.php
@@ -31,7 +31,7 @@ class Presenter {
 
 			$request = new Request(new UrlScript('http://localhost/'));
 			$presenter->injectPrimary(
-				null, null, new RouterStub(), $request, new Response(), null,
+				$request, new Response(), null, new RouterStub(), null,
 				null, $this->createTemplateFactory($request)
 			);
 		}

Maybe we could apply it with composer-patches plug-in.

Edit: Opened #96

@jtojnar jtojnar changed the title Fix tests with nette/component-model Fix tests with nette/component-model 3.1.0 Feb 17, 2024
`Container::getComponents()` returns array when `$deep` is false (by default):
nette/component-model@7f613ee

The method also no longer takes any arguments:
nette/component-model@4e0946a
@f3l1x f3l1x merged commit bde2503 into contributte:master Feb 19, 2024
1 of 4 checks passed
@jtojnar jtojnar deleted the fix-ncm-3.1 branch February 19, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants