Merge pull request #4 from binh-dam-ibigroup/fix-master-actions

Fix master actions
conveyal · Mar 26, 2021 · 31c0163 · 31c0163
2 parents 1b67fd0 + 21af51a
commit 31c0163
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/.github/workflows/node-ci.yml b/.github/workflows/node-ci.yml
@@ -9,10 +9,7 @@ on:
 jobs:
   test-build-release:
     env:
-      GIT_BRANCH_NAME: ${{ github.ref }}
-      IS_PUSH: ${{ github.event_name }}
-      IS_PUSH_TO_MASTER: ${{ github.event.push && github.ref == 'refs/heads/master' }}
-      IS_PUSH_TO_MASTER_ALT: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' }}
+      IS_PUSH_TO_MASTER: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' }}
 
     runs-on: ubuntu-latest
 
@@ -53,5 +50,5 @@ jobs:
       # Deploy storybook demo to S3 if handling a push (non-PR build) on the main branch
       # https://s3.amazonaws.com/transitive.js/index.html
       - name: Deploy storybook to S3
-        if: ${{ env.IS_PUSH_TO_MASTER }}
+        if: ${{ env.IS_PUSH_TO_MASTER == true }}
         run: yarn deploy-storybook
diff --git a/package.json b/package.json
@@ -32,7 +32,7 @@
     "lint": "mastarm lint lib",
     "semantic-release": "semantic-release",
     "start": "start-storybook -p 5555",
-    "deploy-storybook": "storybook-to-aws-s3 --bucket-path=transitive.js --s3-sync-options=--acl=public-read"
+    "deploy-storybook": "storybook-to-aws-s3 --bucket-path=bdam-testbuckt --s3-sync-options=--acl=public-read"
   },
   "devDependencies": {
     "@babel/core": "^7.12.3",