Parser edits

[Seth-Harlaar]

Updated the way the parser parses strings and handles errors.
Major changes:

• parser now separates string at new lines and parses each line separately
• error message indicating where the error was in the line
• only lines that have an error in them are discarded, the rest of the recipe will parse

[Seth-Harlaar]

Things I still have to change before merging:

• make parser separate lines by all acceptable new line characters
• - update error message to show user friendly message indicating error
• - update line counter for error message to properly indicate which line message has an error
• - remove testing printing messages

[Seth-Harlaar]

So far the error message indicates what token trips up the parser. It uses the token definitions from the Cooklang.y file and prints out the token. To me the token names seem pretty clear as to what they represent, but I'm wondering if anyone thinks they should be updated to be more clear. You can look at them here: https://github.com/Seth-Harlaar/cooklang-c/blob/a29c84a6ebc43170e7f562d694367bb2e1c81e6d/src/Cooklang.y#L40

[dubadub]

Token names are pretty clear, indeed. Could you please share an error message example?

[Seth-Harlaar]

Sure!
Let's say the user forgot the left curly bracket in the example input:

Put @ingredient 4} in pot.

The output error message would be the following 2 lines:
Error, syntax error, expected LCURL.
Error at column 16 on line 1.

[Net-Mist]

Hello !
If the PR is not ready to be merged, you can convert if to "draft PR", so it is clear for everyone

[Net-Mist]

also I don't understand the changes in cooklang.l file. We don't want to support UTF-8 anymore ?

[Seth-Harlaar]

Oh, thanks for picking that up, I was making some changes to the parser and removed the UTF-8 to make testing easier. I will revert the changes.

[Net-Mist]

Oh ! Ok !

[Net-Mist]

Hello !
Maybe you are aware of this, but the make parser comment doesn't work. Both on main branch and in this PR. As you're working on it, maybe if you fix it you could then add a github action to check that it doesn't break in the future

[Net-Mist]

parser now separates string at new lines and parses each line separately

How do you plan do manage to parse multi-line block comments ?

[Seth-Harlaar]

Was not aware of make parser not working. It seemed to be working perfectly fine on my system. I will look into it.

Maybe in the parseMultipleLineString function we can check a return value from the parser and see if there is an opening and no closing to a block comment. From there we can tell the parser not to parse anything until it has detected a closing tag.