Boy what the hell (unbreak mods and DynOS packs)

They dug me out of my grave and told me `configSkipPackGeneration`. My heart sank. This feature would have been fine if it was off by default and if it wasn't then people caught it before the version was officially released and the option was promptly disabled without a massive pool of people having this option turned on by default. So I will say, Coolio wasn't really in the wrong by adding this, it should have never been changed to be on by default.
coop-deluxe · Feb 14, 2025 · abf818b · abf818b
1 parent 39ab128
commit abf818b
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 6 deletions.
diff --git a/data/dynos_bin_col.cpp b/data/dynos_bin_col.cpp
@@ -53,7 +53,7 @@ static void ValidateColSectionChange(GfxData* aGfxData, struct CollisionValidati
             PrintDataError("Improper triangle count found in section. Allocated: %u, Defined: %u", aColValData.triAlloc, aColValData.triCount);
         }
         if (aColValData.specialAlloc != aColValData.specialCount) {
-            PrintDataError("Improper sepcial count found in section. Allocated: %u, Defined: %u", aColValData.triAlloc, aColValData.triCount);
+            PrintDataError("Improper special count found in section. Allocated: %u, Defined: %u", aColValData.triAlloc, aColValData.triCount);
         }
         if (aColValData.waterBoxAlloc != aColValData.waterBoxCount) {
             PrintDataError("Improper water box count found in section. Allocated: %u, Defined: %u", aColValData.waterBoxAlloc, aColValData.waterBoxCount);

diff --git a/data/dynos_gfx_init.cpp b/data/dynos_gfx_init.cpp
@@ -4,8 +4,6 @@ extern "C" {
 }
 
 void DynOS_Gfx_GeneratePacks(const char* directory) {
-    if (configSkipPackGeneration) { return; }
-
     LOADING_SCREEN_MUTEX(
         loading_screen_reset_progress_bar();
         snprintf(gCurrLoadingSegment.str, 256, "Generating DynOS Packs In Path:\n\\#808080\\%s", directory);

diff --git a/src/pc/configfile.c b/src/pc/configfile.c
@@ -188,7 +188,6 @@ unsigned int configDjuiScale                      = 0;
 // other
 unsigned int configRulesVersion                   = 0;
 bool         configCompressOnStartup              = false;
-bool         configSkipPackGeneration             = true;
 
 // secrets
 bool configExCoopTheme = false;
@@ -320,7 +319,6 @@ static const struct ConfigOption options[] = {
     // other
     {.name = "rules_version",                  .type = CONFIG_TYPE_UINT,   .uintValue   = &configRulesVersion},
     {.name = "compress_on_startup",            .type = CONFIG_TYPE_BOOL,   .boolValue   = &configCompressOnStartup},
-    {.name = "skip_pack_generation",           .type = CONFIG_TYPE_BOOL,   .boolValue   = &configSkipPackGeneration},
 };
 
 struct SecretConfigOption {

diff --git a/src/pc/configfile.h b/src/pc/configfile.h
@@ -137,7 +137,6 @@ extern unsigned int configDjuiScale;
 // other
 extern unsigned int configRulesVersion;
 extern bool         configCompressOnStartup;
-extern bool         configSkipPackGeneration;
 
 // secrets
 extern bool configExCoopTheme;