Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New logging system with file output #679

Open
wants to merge 27 commits into
base: dev
Choose a base branch
from

Conversation

kermeow
Copy link
Contributor

@kermeow kermeow commented Feb 24, 2025

This is a continuation of #635 that has been rebased with latest dev.
I also went through every file that already contained LOG_* macros to make sure they wouldn't spam the logs.

  • debuglog.h has been replaced with log.h/log.c
  • LOG_* macros have been made to replicate the previous behaviour
  • LOG_*_VERBOSE macros have been made to replicate filename logging and debug print behaviour
  • LOG_DEBUG and LOG_DEBUG_VERBOSE are occluded from release builds

Translation will be needed for the "Verbose Logs" misc option that has replaced the old debug log options.

cc: @iZePlayzYT

iZePlayzYT

This comment was marked as outdated.

@iZePlayzYT
Copy link
Contributor

@AgentXLP @Isaac0-dev can you undo this "approved" please. that was unintentionally

* Update German.ini

* Translated VERBOSE_LOGS to all languages
@kermeow kermeow marked this pull request as ready for review February 28, 2025 20:43
@kermeow
Copy link
Contributor Author

kermeow commented Feb 28, 2025

This seems pretty ready to me now.
If there are any last minute changes needed then now is the perfect time to bring them up!
iZe suggested adding a crash report to the log but I feel like that should be a whole other thing instead of tying everything in with the log file.

A LOT of files were changed here and, while it builds and runs successfully, I don't trust myself to have not forgotten something. plz review @Isaac0-dev 🙏

@iZePlayzYT
Copy link
Contributor

iZePlayzYT commented Feb 28, 2025

@kermeow i didnt mean that we should create a seperate crash log file, but if the game crashes it would be helpful if some details why it crashed would be saved into the normal log file. especially helpful when you already closed the game and still want to report the "bug" or "problem" in discord for example.

i mean logging those infos from a crash screen in the log file too:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants