-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG]] foodhub_custom_product_kanban_view #110
[16.0][MIG]] foodhub_custom_product_kanban_view #110
Conversation
a5a7ee5
to
d0cd168
Compare
@polchampion deployed to test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 16.0 #110 +/- ##
=======================================
Coverage 87.80% 87.80%
=======================================
Files 6 6
Lines 123 123
Branches 15 15
=======================================
Hits 108 108
Misses 9 9
Partials 6 6 ☔ View full report in Codecov by Sentry. |
I don't understand the pre-commit error, seems not related to this code ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
suggestion, non-blocking : first 3 commits (even 6 IMO but Carmen would disagree) could be squashed.
d0cd168
to
46ae409
Compare
@robinkeunen pre-commit fixed and commits squashed. |
[UPD] Update foodhub_custom_product_kanban_view.pot [UPD] README.rst
46ae409
to
8b647d5
Compare
Great, I rebased on fixed 16.0. You'll need to reset your branch to thus one before changing this branch further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
successful functional test
Adapts the product kanban view :
- Removes the Quantity on Hand from the product kanban view.
- Adds Description for Customer on the product kanban view.
@victor-champonnois note that I didn't find how to display the quantity on hand on a clean db, but I could test the module's behaviour on a db where the quantity on hand was already displayed.
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 2620843. Thanks a lot for contributing to coopiteasy. ❤️ |
https://gestion.coopiteasy.be/web#id=10929&action=475&active_id=568&model=project.task&view_type=form&menu_id=536