Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG]] foodhub_custom_product_kanban_view #110

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

@victor-champonnois victor-champonnois changed the title 16.0 mig foodhub custom product kanban view [16.0][MIG]] foodhub_custom_product_kanban_view Feb 1, 2024
@victor-champonnois victor-champonnois force-pushed the 16.0-mig-foodhub_custom_product_kanban_view branch from a5a7ee5 to d0cd168 Compare February 1, 2024 10:19
@victor-champonnois
Copy link
Member Author

@polchampion deployed to test

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58aa354) 87.80% compared to head (46ae409) 87.80%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             16.0     #110   +/-   ##
=======================================
  Coverage   87.80%   87.80%           
=======================================
  Files           6        6           
  Lines         123      123           
  Branches       15       15           
=======================================
  Hits          108      108           
  Misses          9        9           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victor-champonnois
Copy link
Member Author

I don't understand the pre-commit error, seems not related to this code ?

Copy link
Member

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

suggestion, non-blocking : first 3 commits (even 6 IMO but Carmen would disagree) could be squashed.

@victor-champonnois victor-champonnois force-pushed the 16.0-mig-foodhub_custom_product_kanban_view branch from d0cd168 to 46ae409 Compare February 1, 2024 14:22
@victor-champonnois
Copy link
Member Author

@robinkeunen pre-commit fixed and commits squashed.

@robinkeunen robinkeunen force-pushed the 16.0-mig-foodhub_custom_product_kanban_view branch from 46ae409 to 8b647d5 Compare February 1, 2024 17:02
@robinkeunen
Copy link
Member

Great, I rebased on fixed 16.0. You'll need to reset your branch to thus one before changing this branch further.

Copy link
Member

@polchampion polchampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successful functional test

Adapts the product kanban view :

  • Removes the Quantity on Hand from the product kanban view.
  • Adds Description for Customer on the product kanban view.

@victor-champonnois note that I didn't find how to display the quantity on hand on a clean db, but I could test the module's behaviour on a db where the quantity on hand was already displayed.

@victor-champonnois
Copy link
Member Author

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-110-by-victor-champonnois-bump-nobump, awaiting test results.

@github-grap-bot github-grap-bot merged commit 78ebdac into 16.0 Feb 19, 2024
2 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 2620843. Thanks a lot for contributing to coopiteasy. ❤️

@github-grap-bot github-grap-bot deleted the 16.0-mig-foodhub_custom_product_kanban_view branch February 19, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants