feat: Drop support of ocaml_version: "minimal"
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the docker-coq-action is intended to act as a GHA *facade* (to simplify
the CI testing of opam projects using a Docker-Coq image or a custom one),
and as the mapping between valid `coq_version` and `ocaml_version` already
is the responsibility of the Docker-Coq registry, it appears irrelevant to
also maintain one similar mapping in docker-coq-action's `entrypoint.sh`.
Still, the value `ocaml_version: "minimal"` can be safely emulated with:
```
- uses: coq-community/docker-coq-action@v1
with:
ocaml_version: "4.05"
# for 8.10 <= coq_version <= 8.15
#
# or:
#
ocaml_version: "4.09-flambda"
# for coq_version >= 8.16
```
Finally, it can be noted that setting `ocaml_version: "default"` is useful
to directly rely on Docker-Coq's default tag, regarding the ocaml version:
see https://github.com/coq-community/docker-coq/wiki#ocaml-versions-policy
|
When this PR will be merged: minor version bump → |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the docker-coq-action is intended to act as a GHA facade (to simplify the CI testing of opam projects using a Docker-Coq image or a custom one), and as the mapping between valid
coq_versionandocaml_versionalready is the responsibility of the Docker-Coq registry, it appears irrelevant to also maintain one similar mapping in docker-coq-action'sentrypoint.sh.Still, the value
ocaml_version: "minimal"can be safely emulated with:Finally, it can be noted that setting
ocaml_version: "default"is useful to directly rely on Docker-Coq's default tag, regarding the ocaml version: see https://github.com/coq-community/docker-coq/wiki#ocaml-versions-policy