Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate.sh -> Makefile #12

Closed
wants to merge 2 commits into from
Closed

Conversation

liyishuai
Copy link
Member

No description provided.

@Zimmi48
Copy link
Member

Zimmi48 commented Feb 13, 2020

If you do this change, you need to fix the README. Can you briefly summarize the motivation?

Copy link
Member

@palmskog palmskog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand how this improves the (already problematic) situation of integrating a script like generate.sh into an existing project. For example, one needs to control the names of some target files, such as for coq.opam -> coq-myproject.opam, and a Makefile effectively prevents this.

Also, let's say the templates directory lives in some completely different location from the Coq project. How can one then call the Makefile here from the Coq makefile and get paths to work out?

@liyishuai
Copy link
Member Author

I see. I should change the configuration to assume templates in a subdirectory.

@palmskog
Copy link
Member

palmskog commented Feb 13, 2020

My general argument is basically that I don't think a Makefile is flexible enough to accommodate the many workflows which one could incorporate the templates into. In particular, I think we need some kind of solution that works both when templates is in a subdirectory (of the current Coq project) and when it lives somewhere completely different. The parametrization (pattern-matching, really) in Makefiles (%.mustache and so on) is also lacking in flexibility. Finally, not many people will want to use files like the index.md template by default (it's an "extra" when there is a website).

The current generate.sh script is not great at all, but I think there should at least be some improvement on the above issues for a replacement.

@liyishuai liyishuai force-pushed the master branch 3 times, most recently from 447f63c to 3265d08 Compare February 13, 2020 21:01
@liyishuai liyishuai requested a review from palmskog February 13, 2020 21:10
@liyishuai liyishuai force-pushed the master branch 3 times, most recently from 76f1acd to c76ce7a Compare February 13, 2020 21:21
@liyishuai
Copy link
Member Author

Changes:

  • Moved example to subfolder
  • Specific rules for .opam files
  • Replaced target index.md with index.html

@Zimmi48
Copy link
Member

Zimmi48 commented May 1, 2020

If I understood correctly, this PR has been made obsolete by #26 and all that remains to do is to address #20 and #24.

@Zimmi48 Zimmi48 closed this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants