-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate.sh -> Makefile #12
Conversation
If you do this change, you need to fix the README. Can you briefly summarize the motivation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand how this improves the (already problematic) situation of integrating a script like generate.sh
into an existing project. For example, one needs to control the names of some target files, such as for coq.opam
-> coq-myproject.opam
, and a Makefile effectively prevents this.
Also, let's say the templates
directory lives in some completely different location from the Coq project. How can one then call the Makefile here from the Coq makefile and get paths to work out?
I see. I should change the configuration to assume |
My general argument is basically that I don't think a Makefile is flexible enough to accommodate the many workflows which one could incorporate the templates into. In particular, I think we need some kind of solution that works both when The current |
447f63c
to
3265d08
Compare
76f1acd
to
c76ce7a
Compare
Changes:
|
No description provided.