Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging branch support #62

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Staging branch support #62

merged 6 commits into from
Jan 17, 2025

Conversation

mattam82
Copy link
Member

Adds support for a staging (and other non-main branches), with a banner linking to the branch (on github) and indicating the commit the website was built for, if the branch is not main. The commit and branch (even for main) is also always visible in any generated html page if you look at the source (it's a hidden

in the footer).

@mattam82
Copy link
Member Author

@BastienSozeau can you fix the banner display? I don't see how to do it :)

@BastienSozeau
Copy link
Collaborator

I applied the fix on the staging branch.
I put the fixed banner at the bottom to avoid breaking the display of the navigation and the breadcrumbs.

I also removed the unnecessary stylesheet and added a closing condition for the if git_branch <> "main" statement

@mattam82
Copy link
Member Author

Great, I’ll fix the tests and merge

@mattam82 mattam82 merged commit 77b8f68 into main Jan 17, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants