Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten rocq-lsp #73

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Shorten rocq-lsp #73

merged 1 commit into from
Jan 25, 2025

Conversation

gares
Copy link
Member

@gares gares commented Jan 23, 2025

This PR does two things:

  • use the current name of the opam package for vscoq-language-server
  • makes the rocq-lsp entry not-a-copy of the vscoq one, and makes it sensibly shorter.

Given there is another page on how to install vscoq, we could short that section as well and link to that tutorial.

@gares gares requested a review from Zimmi48 January 23, 2025 20:31
@Zimmi48
Copy link
Member

Zimmi48 commented Jan 24, 2025

Given there is another page on how to install vscoq, we could short that section as well and link to that tutorial.

What other page? Are you talking about the one that was removed as part of #59?

@Zimmi48
Copy link
Member

Zimmi48 commented Jan 24, 2025

I'm fine with merging these changes, but:

  • they should be done for all the OS (currently only done for one)
  • so far, the way things have been done on the website is to link to future things that do not exist yet (lots of broken URLs). Given that Rocq 9.0+rc1 is out anyway, won't the vsrocq-language-server opam package be released relatively soon?

@gares
Copy link
Member Author

gares commented Jan 24, 2025

Oh, didn't notice the instructions were per-OS. fixed.

I let @rtetley comment on the package (re)name

@rtetley
Copy link

rtetley commented Jan 24, 2025

The plan was to do a release in two weeks. But there is nothing set in stone, we could always proceed earlier if necessary.

@gares
Copy link
Member Author

gares commented Jan 24, 2025

And that release could have the new name (opam side) and we could have an empty package just depending on the new one to not break user's setup.

At the same time, I don't know how to handle the transition in the app store, would the same strategy work?

@Zimmi48
Copy link
Member

Zimmi48 commented Jan 25, 2025

At the same time, I don't know how to handle the transition in the app store, would the same strategy work?

On the app store, it's time not to call this extension maximedenes.vscoq anymore.
A rocq-prover organization should be created first. Then, then extension can be called rocq-prover.vsrocq. I guess it should be fine to keep publishing it in both places, or you can just mark maximedenes.vscoq as deprecated and stop updating it.

@Zimmi48 Zimmi48 changed the title Fix opam line for vsrocq, shorten rocq-lsp Shorten rocq-lsp Jan 25, 2025
@Zimmi48 Zimmi48 merged commit 86f0b76 into main Jan 25, 2025
3 checks passed
@Zimmi48 Zimmi48 deleted the gares-patch-1 branch January 25, 2025 11:56
@rtetley
Copy link

rtetley commented Jan 25, 2025

I already created the organisation to prepare for this. Indeed deprecating the old one is a solution but we lose the download stats and ratings

@Zimmi48
Copy link
Member

Zimmi48 commented Jan 25, 2025

Otherwise, is there support from transferring and renaming in the VS Code marketplace? If yes, that would likely be the best option.

@rtetley
Copy link

rtetley commented Jan 29, 2025

So from my research, I could theoretically contact vscode marketplace support team and rename the extension. This what would happen though (from this stack overflow thread):

The download stats would remain same even after the extension transfer. Usually, we do not allow transfer of VSCode extensions since it has following consequences:

  1. Users will not be able to install the older versions of your extensions that got published before the extension transfer from the VSCode.
  2. If this extension is used as a dependency in other extensions by using publisherName.ExtensionName, that would not work.
  3. You need to update all references to this extension with the new publisherName.

I will still contact support and see.

@Zimmi48
Copy link
Member

Zimmi48 commented Jan 29, 2025

To me, it looks like points 2 and 3 are not an issue. Point 1 is indeed an issue, but it could be worked around by re-publishing all the past versions.

@rtetley
Copy link

rtetley commented Jan 29, 2025

Well I contacted vscode marketplace support, they suggested we deprecate the extension. See: microsoft/vscode-discussions#1

I am not sure they change the publisher name anymore :-/

@Zimmi48
Copy link
Member

Zimmi48 commented Jan 30, 2025

Well, I think this solution is fine as well. Statistics on the new extension will go up fast again. Especially with the previous extension deprecated and pointing to the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants