-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables to print papers filtered by a tag + details button to display the full list #82
base: main
Are you sure you want to change the base?
Conversation
Let's try this on staging |
Should be up in a minute at https://staging.rocq-prover.org (commit 42cd4a9) |
I'm fine with it, probably we can improve the "More Papers" placement / visibility. @BastienSozeau ? |
Actually, if you search and hit enter your get a page with the results hidden under More Papers, that's broken to me. |
6c2455f
to
b75cd12
Compare
Right, the details button close when searching. So it filters correctly but do not work with |
I have written a small fix that checks if a query has been permformed and if so open the details, but it only works if the function is used once. If used several times, it bugs. I am sorry, I don't know how to do better. |
I guess @BastienSozeau might know how to do better. I also think the "recommended papers" should disappear once a query has been done. |
I don't think it makes sense to keep the recommended papers when you enter a search, so I removed that section when a query (even an empty one) has been made. I think it's looking better now. Still have the common issue of jumping to #results in the page being hidden by the top bar... as in #88 |
I'm deploying on staging for testing |
@thomas-lamiaux @BastienSozeau please have a look! |
I am not managing to check the last deployment on my phone, sth is wrong with the app. Could you post the url |
This is a small PR to enable us to print papers by categories on Learn/paper webpage
PS: if you filter, then the search does search in the filtered papers so all works well