Skip to content

Commit

Permalink
feat(slider): fix synchronization between slider inner and props values
Browse files Browse the repository at this point in the history
  • Loading branch information
Haskiro committed Feb 10, 2025
1 parent e1cb975 commit 6e30c07
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changeset/moody-tips-visit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@alfalab/core-components-select': patch
---

Исправлена синхронизация между значениями из пропсов и внутри слайдера
12 changes: 8 additions & 4 deletions packages/slider/src/Component.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { FC, useEffect, useRef } from 'react';
import React, { FC, useEffect, useRef, useState } from 'react';
import cn from 'classnames';
import noUiSlider, { API, Options } from 'nouislider';

Expand Down Expand Up @@ -131,8 +131,10 @@ export const Slider: FC<SliderProps> = ({
onEnd,
dataTestId,
}) => {
const [syncValues, setSyncValues] = useState(false);
const sliderRef = useRef<(HTMLDivElement & { noUiSlider: API }) | null>(null);
const busyRef = useRef<boolean>(false);

const hasValueTo = valueTo !== undefined;

const getSlider = () => sliderRef.current?.noUiSlider;
Expand Down Expand Up @@ -167,6 +169,7 @@ export const Slider: FC<SliderProps> = ({

slider.on('change', () => {
busyRef.current = false;
setSyncValues(true);
onEnd?.();
});

Expand Down Expand Up @@ -194,16 +197,17 @@ export const Slider: FC<SliderProps> = ({

useEffect(() => {
const slider = getSlider();

// Пропускаем обновление, если происходит взаимодействие со слайдером
if (slider && busyRef.current === false) {
if (slider && (!busyRef.current || syncValues)) {
if (valueTo) {
slider.set([value, valueTo], false);
} else {
slider.set(value, false);
}

setSyncValues(false);
}
}, [value, valueTo]);
}, [value, valueTo, syncValues]);

useEffect(() => {
const slider = getSlider();
Expand Down

0 comments on commit 6e30c07

Please sign in to comment.