-
Notifications
You must be signed in to change notification settings - Fork 58
fix(cdn-icon): fix icon update when name changes #1558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eb0530d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 13587171395Details
💛 - Coveralls |
Собрана новая демка. |
fulcanellee
approved these changes
Feb 3, 2025
Собрана новая демка. |
Собрана новая демка. |
hextion
requested changes
Feb 10, 2025
Собрана новая демка. |
SiebenSieben
approved these changes
Feb 21, 2025
hextion
requested changes
Feb 24, 2025
fulcanellee
pushed a commit
that referenced
this pull request
Mar 4, 2025
* fix(cdn-icon): fix icon update when name changes * refactor(cdn-icon): extract useIcon hook, add useSyncExternalStore hook * fix(cdn-icon): add core-components-shared dependency * chore(cdn-icon): fix quick-vans-return.md * chore(cdn-icon): fix quick-vans-return.md * fix: update dependencies --------- Co-authored-by: Elena Spivak <[email protected]> Co-authored-by: Mikhail Lukin <[email protected]> (cherry picked from commit 202249e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача https://jira.moscow.alfaintra.net/browse/DS-9094
Опишите проблему
При изменении пропса
name
CDNIсon не перерисовывает иконкуШаги для воспроизведения
Ожидаемое поведение