Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/steps rework #1580

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Feat/steps rework #1580

wants to merge 7 commits into from

Conversation

fulcanellee
Copy link
Collaborator

@fulcanellee fulcanellee commented Feb 12, 2025

https://jira.moscow.alfaintra.net/browse/DS-8487

  • Изменение отступов между шагами
  • Добавление пропса по изменению цвета dash
  • Добавлен новый статус CriticalError

Copy link

changeset-bot bot commented Feb 12, 2025

🦋 Changeset detected

Latest commit: 305b549

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-steps Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fulcanellee fulcanellee requested a review from Oladii February 12, 2025 13:52
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@coveralls
Copy link

coveralls commented Feb 13, 2025

Pull Request Test Coverage Report for Build 13429872032

Details

  • 17 of 18 (94.44%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 82.224%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/steps/src/components/step/Component.tsx 10 11 90.91%
Totals Coverage Status
Change from base Build 13428442718: 0.01%
Covered Lines: 11242
Relevant Lines: 12471

💛 - Coveralls

@SiebenSieben
Copy link
Contributor

Пригласите корпоратов на дизайн и код ревью пжлст

@SiebenSieben
Copy link
Contributor

@hextion

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

core-ds-bot commented Feb 20, 2025

Bundle size report

Entry point Size (minified)
steps/index.js 8.8 (+1.00 KB🔺)

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants