forked from mbj4668/pyang
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base to current pyang master (2.6.1 plus something) #9
Open
cabo
wants to merge
42
commits into
master
Choose a base branch
from
update-base
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add <<enumeration>> stereotype to an enumeration class Add support for rendering a typedef of bits as a bits class Add support for defining the max number of bit values to render in the bits class. Add support to indicate that more enum or bit values are not shown by means of an ellipsis
… module being rendered
This refactoring allows for more alternatives in the future.
Remove unnecessary variables. Add support for association.
Shorten and simplify descriptions of new UML options where possible. Align more with existing descriptions, even if not 100% correct. Simplify code where applicable.
…ml-no Also correct error in uml-case which references the wrong set of strings, if the option includes an invalid string.
Exitsing ctx_title renamed ctx_title_text so that ctx_title could be used for uml-no.
Correct default assignment to glob in function emit_grouping, should be Boolean not string.
Modifies the info message to quote the name of the grouping rather than the PlantUML keyword of the parent node of the uses statement, which may not be understandable to uses not familiar with PlantUML code.
… keywords PlantUML does not accept dots in keywords, but the current UML plugin does not convert dots in keywords (as permitted for YANG identifiers by RFC 7950 section 6.2) to underscores. Also to ensure there is no chance of a clash of keywords where say both the identifiers 'a.b' and 'a-b' exist, use 2 underscores for dots.
Whether further child statements should be rendered depends on whether cont=true when emit_child_stmt() is called and by augments it is set to false, but emit_notify() always emits child statements. So this change moves the the call to emit_child_stmt() out of emit_notify() in the same way that this is done for lists.
…rules in XPath evaluations
* Replace sys.exit with return, and create an error object for the IOError prior to returning. If other modules import this code, an exit in a library may have unintended consequences. Like in other places, use return instead of exit. --------- Co-authored-by: Joe Clarke <[email protected]>
This addresses mbj4668#893 Signed-off-by: Siddharth Sharma <[email protected]>
Depending on Python version use pkg_resources (old behavior) or use importlib to check for plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.