Plugin: Reset stack limit at draining time #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awelzel
force-pushed
the
topic/awelzel/set-stack-limit-at-drain-time
branch
from
5fd25e3 to
09e984e
Compare
awelzel
changed the title
awelzel
changed the title
Spicy is using alternative stacks to execute fibres and may drain and execute events on these alternative stacks. E.g., this happens during DataIn() and subsequent GetFileID() calls. This confuses V8's own stack limit checking, reporting that the call stack was exceeded. Reset the stack limit whenever events are drained, or the IO sources Process() method is called. This was triggered when implementing file_state_remove() with the spicy-zip analyzer enabled and analyzing a ZIP file.
awelzel
force-pushed
the
topic/awelzel/set-stack-limit-at-drain-time
branch
from
09e984e to
aaf59fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spicy is using alternative stacks to execute fibres and may drain
and execute events on these alternative stacks. E.g., this happens
during DataIn() and subsequent GetFileID() calls.
This confuses V8's own stack limit checking, reporting that the call
stack was exceeded.
Reset the stack limit whenever events are drained, or the IO sources
Process() method is called.
This was triggered when implementing file_state_remove() with the
spicy-zip analyzer enabled and analyzing a ZIP file.