ci: Add crates.io trusted publishing on tag push#1086
Open
cgwalters wants to merge 1 commit into
Open
Conversation
Adopt the same trusted-publishing approach used by bootc-dev/bootc so that cargo publish happens automatically when a v* tag is pushed, with no stored API tokens needed. The new crates-release.yml workflow obtains an OIDC token via rust-lang/crates-io-auth-action and publishes idempotently (skips if the version is already on crates.io). The release checklist is updated to note the automation, remove the now-unnecessary crates.io account requirements, and fix the vendor tarball extension (.tar.gz → .tar.zstd). One-time setup: configure a trusted publisher on crates.io for the bootupd crate (owner: coreos/bootupd, workflow: crates-release.yml). Assisted-by: OpenCode (Claude Opus 4) Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the release checklist and package configuration to transition toward automated crates.io publishing using trusted publishing (OIDC). Key changes include removing manual credential requirements from the checklist, updating the vendor archive format to Zstandard, and enabling publishing in the release metadata. Review feedback highlights that the referenced workflow file is missing from the PR, suggests maintaining the disable-publish setting in Cargo.toml to prevent accidental manual releases, and recommends using the standard .tar.zst file extension for better compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt the same trusted-publishing approach used by bootc-dev/bootc so that cargo publish happens automatically when a v* tag is pushed, with no stored API tokens needed.
The new crates-release.yml workflow obtains an OIDC token via rust-lang/crates-io-auth-action and publishes idempotently (skips if the version is already on crates.io).
The release checklist is updated to note the automation, remove the now-unnecessary crates.io account requirements, and fix the vendor tarball extension (.tar.gz → .tar.zstd).
One-time setup: configure a trusted publisher on crates.io for the
bootupd crate (owner: coreos/bootupd, workflow: crates-release.yml).
Assisted-by: OpenCode (Claude Opus 4)