tests/platforms: add test for Azure SR-IOV udev rules #3947
+66
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new test to verify that Azure SR-IOV network interfaces are correctly marked as unmanaged by NetworkManager. The test script is well-structured and the logic is sound. I have one suggestion to improve the efficiency of the script by reducing redundant calls to nmcli within a loop. Overall, this is a valuable addition to the test suite.
aaradhak
force-pushed
the
azuresriov
branch
2 times, most recently
from
9e78dca to
8bebbcc
Compare
Introduce a new test which verifies that udev rules for Azure SR-IOV network interfaces correctly mark them as unmanaged by NetworkManager. It only runs on Azure and uses Standard_D2s_v3 or larger instance type with Accelerated Networking enabled. The test checks that SR-IOV interfaces (PCI devices with vendor drivers like mlx5_core) have the AZURE_UNMANAGED_SRIOV property set, and that NetworkManager respects this property by leaving them unmanaged. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
travier
reviewed
Jan 14, 2026
| @@ -0,0 +1 @@ | |||
| /home/aaradhak/coderepo/fedora-coreos-config No newline at end of file | |||
Member
There was a problem hiding this comment.
You probably did not want to include this one
| fi | ||
| done | ||
|
|
||
| nm_devices=$(nmcli -t -f DEVICE,STATE device) |
Member
There was a problem hiding this comment.
Looks OK as is but can we get this in JSON format? That would be a bit nicer.
| fi | ||
| fi | ||
| done | ||
|
|
Member
|
You also have an override file that you probably don't want there: overrides/rootfs/usr/libexec/ignition-apply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new test which verifies that udev rules for Azure SR-IOV network interfaces correctly mark them as unmanaged by NetworkManager. It only runs on Azure and uses Standard_D2s_v3 or larger instance type with Accelerated Networking enabled.
The test checks that SR-IOV interfaces (PCI devices with vendor drivers like mlx5_core) have the AZURE_UNMANAGED_SRIOV property set, and that NetworkManager respects this property by leaving them unmanaged.