.tekton: increase clone depth #3965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 5c83258, we need to have a git tree containing more commits than just 1 (the default), because the python script versionary calculates the `n` value based on the number of commits. This patch increases the number of commits to clone up to 50. We expect not having more than 50 commits since the last manifest lockfile update.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly increases the git clone depth to 50 for Tekton pipelines to support the versionary script. The change is applied across all relevant pipeline configurations. However, this approach introduces significant duplication of the clone-depth parameter and the pipeline bundle SHA across 17 files. This will make future maintenance more difficult. My review includes a suggestion to centralize this configuration using a tool like Kustomize to improve maintainability.
Member
Author
|
FTR the Konflux log of this PR: |
jbtrystram
approved these changes
Jan 15, 2026
dustymabe
approved these changes
Jan 15, 2026
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 5c83258, we need to have a git tree containing more commits than just 1 (the default), because the python script versionary calculates the
nvalue based on the number of commits. This patch increases the number of commits to clone up to 50. We expect not having more than 50 commits since the last manifest lockfile update.