overlay/core: write ignition issues to /run#4046
Open
jbtrystram wants to merge 2 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the coreos-ignition-write-issues script to write ignition issue files to /run/issue.d instead of /etc/issue.d. This change aligns with modern agetty behavior, which now sources issue files from /run. The changes in the script are correct and the removal of the workaround symlink is appropriate. However, a related test file has not been updated, which will cause CI to fail. Please see the specific comment for details.
jbtrystram
force-pushed
the
write-issues-to-run
branch
from
34319dc to
e521f1a
Compare
Member
Author
|
So this will break on all the RHCOS versions we currently build because |
jbtrystram
force-pushed
the
write-issues-to-run
branch
2 times, most recently
from
9f96233 to
c7aee76
Compare
Member
Author
|
/retest |
dustymabe
reviewed
Mar 10, 2026
jbtrystram
added a commit
to jbtrystram/rhel-coreos-config
that referenced
this pull request
Mar 24, 2026
Symlink ignition issues to /etc/issues.d Since util-linux 2.41 agetty will source issues from /run so we moved FCOS to write the generated issues there in [1]. Until we have util-linux >= 2.41 we need to symlink these back to /etc/issue.d/. [1] coreos/fedora-coreos-config#4046
jbtrystram
force-pushed
the
write-issues-to-run
branch
from
c7aee76 to
2a7c73f
Compare
jbtrystram
added a commit
to jbtrystram/rhel-coreos-config
that referenced
this pull request
Mar 24, 2026
Symlink ignition issues to /etc/issues.d Since util-linux 2.41 agetty will source issues from /run so we moved FCOS to write the generated issues there in [1]. Until we have util-linux >= 2.41 we need to symlink these back to /etc/issue.d/. [1] coreos/fedora-coreos-config#4046
jbtrystram
added a commit
to jbtrystram/rhel-coreos-config
that referenced
this pull request
Mar 24, 2026
Symlink ignition issues to /etc/issues.d Since util-linux 2.41 agetty will source issues from /run so we moved FCOS to write the generated issues there in [1]. Until we have util-linux >= 2.41 we need to symlink these back to /etc/issue.d/. [1] coreos/fedora-coreos-config#4046
jbtrystram
added a commit
to jbtrystram/rhel-coreos-config
that referenced
this pull request
Mar 24, 2026
Symlink ignition issues to /etc/issues.d Since util-linux 2.41 agetty will source issues from /run so we moved FCOS to write the generated issues there in [1]. Until we have util-linux >= 2.41 we need to symlink these back to /etc/issue.d/. [1] coreos/fedora-coreos-config#4046
jbtrystram
added a commit
to jbtrystram/rhel-coreos-config
that referenced
this pull request
Mar 24, 2026
Symlink ignition issues to /etc/issues.d Since util-linux 2.41 agetty will source issues from /run so we moved FCOS to write the generated issues there in [1]. Until we have util-linux >= 2.41 we need to symlink these back to /etc/issue.d/. [1] coreos/fedora-coreos-config#4046
jbtrystram
added a commit
to jbtrystram/rhel-coreos-config
that referenced
this pull request
Mar 25, 2026
Symlink ignition issues to /etc/issues.d Since util-linux 2.41 agetty will source issues from /run so we moved FCOS to write the generated issues there in [1]. Until we have util-linux >= 2.41 we need to symlink these back to /etc/issue.d/. [1] coreos/fedora-coreos-config#4046
jbtrystram
force-pushed
the
write-issues-to-run
branch
from
2a7c73f to
d554615
Compare
Since util-linux 2.41[1] agetty will source issues from multiples places by default (`/etc/`, `/run/` and `/usr/lib/`). Systemd also worked around this [2] since v258 which has been in fedora 43 for a while now, so let's always write our issues to `/run`. [1] util-linux/util-linux@508fb0e [2] systemd/systemd@864a5e9 Ref coreos/fedora-coreos-tracker#2108 See coreos/console-login-helper-messages#130
In CLHM v0.22.0 we switched writing issues to `/run` instead of `/etc` now that `util-linux` looks there by default. Adjust the test. Needs fedora-selinux/selinux-policy#3169
jbtrystram
force-pushed
the
write-issues-to-run
branch
from
d554615 to
2a5b209
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since util-linux 2.41[1] agetty will source issues from multiples places by default (
/etc,/run/and/usr/lib).Systemd also worked around [2] this since v258 which has been in fedora 43 for a while now, so let's always write our issues to
/run.[1]
util-linux/util-linux@508fb0e
[2] systemd/systemd@864a5e9
Ref coreos/fedora-coreos-tracker#2108
See coreos/console-login-helper-messages#130