-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Multiple Bug Fixes for Reviews on Apartments #390
base: main
Are you sure you want to change the base?
Conversation
[diff-counting] Significant lines: 69. |
Parsa Tehranipoor seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
PR Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix was effective in no longer allowing users to like their own review as requested in the bug. However, as the "Helpful" button is still active, when a user clicks the like button on their own review, the button still reacts to their click visually but does not increment the likes count. While this does fix the bug, it would be clearer for users if you could disable the button too for their own reviews – this would still display the button visually but when a user clicks the button, it does not visually react (i.e. turn gray). Good job on one of your first bug fixes on CUApts, though! Keep going :)
Summary
This pull request addresses various bugs pertaining to reviews displayed on apartment pages. This PR builds upon my first PR for fixing an issue revolving around users' self-liking their own reviews and includes more bug fixes for fixing rendering issues and making changes to review categories. Addressing comments on this PR and re-committing kea-roy's changes, which were accidentally overridden, are the only things left for this PR.
Test Plan
To test the first task, one user is required to create a comment and attempt to like it and see that it fails.

For the second one, I checked that all data on the 'communication' and 'value' categories for reviews were removed from the codebase through find and replace. Also checked that the formatting for displayed categories is
### Notes
For the third task, check that after a review deletion or edit, a toast notification pops off, and the review disappears.




For the fourth task, I checked whether or not the most liked review was the one displayed on the apartment scroll page


Breaking Changes