Interview Scheduler Admin View #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 389. |
jujulcrane
reviewed
Feb 23, 2025
| return false; | ||
| }); | ||
|
|
||
| if (missingHeader) return; |
There was a problem hiding this comment.
This logic is kind of complicated so maybe you could move it to a separate utility function that parses csv files
jujulcrane
reviewed
Feb 24, 2025
Comment on lines
30
to
38
| onClick={() => { | ||
| InterviewSchedulerAPI.deleteInstance(uuid).then(() => { | ||
| setInstances((instances) => instances.filter((inst) => inst.uuid !== uuid)); | ||
| }); | ||
| setIsOpen(false); | ||
| }} | ||
| > | ||
| Yes | ||
| </Button> |
There was a problem hiding this comment.
maybe you could add a success message or feedback to the user after successfully deleting? you could also perhaps separate the delete logic into a separate function
jujulcrane
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the admin view of the interview scheduler tool. Admins are allowed to handle all basic CRUD operations for an interview scheduler instance. Applicants are specified via a CSV file. Instances can be closed to prevent further updates on signing up.
Test Plan
2025-03-02.11-32-42.mp4