Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Giving Day] New Heros #874

Merged
merged 17 commits into from
Mar 5, 2025
41 changes: 41 additions & 0 deletions new-dti-website/components/hero.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import SectionWrapper from './hoc/SectionWrapper';

type HeroProps = {
title: string;
description: string;
image: {
src: string;
alt: string;
};
action?: {
buttonText: string;
link: string;
disabled?: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the Apply button in hero section to be disabled when applications not open

};
};

const Hero = ({ title, description, image, action }: HeroProps) => (
<SectionWrapper id={`${title} hero`}>
<img src={image.src} alt={image.alt} height={600} className="w-[100%] rounded-[16px]" />
<div className="flex flex-col gap-4">
<div className="flex flex-col gap-2">
<h1 className="md:text-[40px] md:leading-[46px] font-bold mt-4 xs:text-[32px] xs:leading-[36.8px] text-[#ffffff]">
{title}
</h1>
<p className="md:text-[18px] text-hero-secondary leading-[28.8px]">{description}</p>
</div>
{action &&
(action.disabled ? (
<button className="primary-button opacity-50 cursor-not-allowed" disabled={true}>
{action.buttonText}
</button>
) : (
<a className="primary-button" href={action.link}>
{action.buttonText}
</a>
))}
Comment on lines +27 to +36
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding this for future reference:

  • we shouldn't be disabling links (source)
  • we're instead rendering a disabled <button> component if the CTA action isn't meant to be interacted with. This <button> elem doesn't need to be keyboard focusable according to docs

</div>
</SectionWrapper>
);

export default Hero;
239 changes: 0 additions & 239 deletions new-dti-website/components/team/TeamHero.tsx

This file was deleted.

46 changes: 0 additions & 46 deletions new-dti-website/components/team/data/carousel.json

This file was deleted.

Binary file added new-dti-website/public/images/about-hero.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added new-dti-website/public/images/apply-hero.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed new-dti-website/public/images/carousel-frame.png
Binary file not shown.
Binary file added new-dti-website/public/images/course-hero.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 0 additions & 9 deletions new-dti-website/public/images/outreach_1.svg

This file was deleted.

9 changes: 0 additions & 9 deletions new-dti-website/public/images/outreach_2.svg

This file was deleted.

9 changes: 0 additions & 9 deletions new-dti-website/public/images/outreach_3.svg

This file was deleted.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 0 additions & 9 deletions new-dti-website/public/images/teaching_1.svg

This file was deleted.

9 changes: 0 additions & 9 deletions new-dti-website/public/images/teaching_2.svg

This file was deleted.

9 changes: 0 additions & 9 deletions new-dti-website/public/images/teaching_3.svg

This file was deleted.

Binary file removed new-dti-website/public/images/team/business.png
Binary file not shown.
Binary file removed new-dti-website/public/images/team/design.png
Binary file not shown.
Binary file not shown.
Binary file removed new-dti-website/public/images/team/leads.png
Binary file not shown.
Binary file removed new-dti-website/public/images/team/product.png
Binary file not shown.
Loading
Loading