feat(NiftiVolumeLoader): enable the nifti-volume-loader to read nifti file with datatype such as int32, float64, int8, uint16 and uint32. Because there is something wrong with function ‘createInt16SharedArray’ and ‘createUint16SharedArray’(window.crossOriginIsolated is false), Float32SharedArray is used for representing datatypes except for uint8. #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…array such as Int32
…e is something wrong with function 'createInt16SharedArray' and 'createUint16SharedArray' because window.crossOriginIsolated is false
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Can you please share the data to test this? |
Of course, I've uploaded the data to http://116.63.104.172/nifti_data.zip |
|
@SuperSuperKey Ok i"m much more free from now on |
Sure, I've uploaded the data to google drive (https://drive.google.com/file/d/1sLOBm3PGT2XOAWdPRdcyMLZ7tOB9fCcT/view?usp=drive_link). |
7 tasks
|
Thank you for your PR. I believe this new PR offers better support, so I will close your PR in favor of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
[Feature Request] #964
Changes & Results
Before: The nifti-volume-loader can not read nifti file with datatype such as int32, float64, int8, uint16 and uint32, so the cornerstone3D cannot render them.
After: The nifti-volume-loader can read nifti file with datatype such as int32, float64, int8, uint16 and uint32.
Testing
Use the nifti-volume-loader component to load nifti file with datatype such as int32, float64, int8, uint16 and uint32.
Checklist
PR
semantic-release format and guidelines.
Code
My code has been well-documented (function documentation, inline comments,
etc.)
I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment