fix(package): use itk morphology filter and polyseg dynamically #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sedghi
changed the title
sedghi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1792
This pull request includes several changes to improve the handling of dynamic imports and update the interpolation functionality. The most important changes include converting
peerImportto return aPromise, updating the interpolation buttons and functionality, and handling dynamic imports for specific modules.Improvements to dynamic imports:
packages/tools/src/tools/segmentation/strategies/compositions/labelmapInterpolation.ts: Replaced static imports withpeerImportfor themorphological-contour-interpolationmodule. [1] [2]Updates to interpolation functionality:
packages/tools/examples/labelmapInterpolation/index.ts: Updated button titles and instructions for interpolation, and added new buttons for extended and overlapping interpolation. [1] [2] [3] [4]Handling dynamic imports for specific modules:
packages/tools/src/workers/polySegConverters.js: Added dynamic import handling for the@icr/polyseg-wasmmodule and updated related methods. [1] [2] [3] [4]