Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(labelmap): only show labelmap as independent component on mip if same size #1810

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Feb 4, 2025

This pull request includes updates to dependencies, improvements to error handling, and enhancements to the logic for handling labelmaps in the CrosshairsTool and Labelmap tools. The most important changes are outlined below:

Dependency Updates:

  • Updated the @microsoft/api-extractor package from version 7.48.0 to 7.49.2 in package.json.

Error Handling Improvements:

  • Added a check to return early if enabledElement is not found in the CrosshairsTool class, improving robustness.

Logic Enhancements:

  • Added a dimension check to decide whether to use independent components for blending in the addLabelmapToElement function. This ensures that if dimensions don't match, the code falls back to regular volume addition.

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 25ec65c
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/67a29aafedf934000846ce12
😎 Deploy Preview https://deploy-preview-1810--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi changed the title mip labelmap memoery fix(labelmap): only show labelmap as independent component on mip if same size Feb 4, 2025
@sedghi sedghi merged commit d2e291e into main Feb 4, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant