Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit for fixing video segmentations #1828

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

minimal-scouser
Copy link
Contributor

@minimal-scouser minimal-scouser commented Feb 14, 2025

Context

Video segmentations are broken in cornerstone3d. Well sort of. They are working but they are not properly tied to a frame. Rather they persist across frames which is not ideal.

They used to work in 3d 1.0

Changes & Results

I sense that the mappings of derivedImageId and the currentImageId are not proper, and I confirmed that for every imageId, the mapped derivedImageId is same, which is why these labelmaps are being carried forward.

working demo after changes

compressed-video.mp4

Testing

run the videosegmentation example

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit f1392ee
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/67aef5abb360910008c82cc4
😎 Deploy Preview https://deploy-preview-1828--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant