feat(surface-segmentation): add visibilty configuration for surface segmentation #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
IbrahimCSAE
commented
Feb 24, 2025
| @@ -76,11 +77,12 @@ export function getSurfaceActorEntry( | |||
| segmentationId: string, | |||
| segmentIndex?: number | string | |||
| ) { | |||
| return getActorEntry(viewportId, segmentationId, (actor) => | |||
| // @ts-expect-error | |||
| actor.representationUID?.startsWith( | |||
There was a problem hiding this comment.
this gave me so much pain... 4 hours to figure out what was going on
this is not good because it will match Surface-1 with Surface 10, 11 , 12, 13, 14, 15 etc, or Surface-2 with 21, 22, 23.
such a horrible bug because it was saying there's an actor for a segment when there isn't one. I did the fix for labelmap as well because I assume it can happen there too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adds visibility configuration to surface segmentations
Fixes: OHIF/Viewers#4796
Fixes: https://linear.app/ohif/issue/OHI-1667