Skip to content

Conversation

@sedghi
Copy link
Member

@sedghi sedghi commented Apr 14, 2025

fixes #1996

This pull request includes significant changes to the stackToVolumeFusion example, improvements to the BaseVolumeViewport class, and updates to the testing configuration and test cases. The most important changes are detailed below.

New Example Implementation:

  • packages/core/examples/stackToVolumeFusion/index.ts: Added a new example demonstrating stack to volume fusion and volume with labelmap segmentation. This includes initializing the rendering engine, creating viewports, and setting up volumes and segmentations.

Rendering Engine Enhancements:

Testing Configuration and Test Cases:

CC @wayfarer3130

@netlify
Copy link

netlify bot commented Apr 14, 2025

Deploy Preview for cornerstone-3d-docs canceled.

Name Link
🔨 Latest commit d8d384d
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/67fd41dfae93ef0008f12de3

@sedghi sedghi requested a review from Copilot April 14, 2025 16:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

tests/stackToVolumeFusion.spec.ts:17

  • [nitpick] Consider using a dynamic waiting mechanism (e.g., waitForSelector) instead of a fixed timeout to improve test reliability.
await page.waitForTimeout(2000);

@sedghi sedghi changed the title fix/zoom multiple actor fix(zoom): fix Stack to Volume Fusion and Viewport zoom preservation Apr 14, 2025
@sedghi sedghi requested a review from wayfarer3130 April 14, 2025 17:21
@wayfarer3130
Copy link
Collaborator

Can you add the new example to the examples list?

@sedghi
Copy link
Member Author

sedghi commented Apr 16, 2025

I didn't really plan to use it for showcasing; I think the example page is already pretty crowded. My intention was to use it for end-to-end tests.

@sedghi sedghi merged commit b4c8764 into main Apr 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] zoom of 1 not consistent between stack and volume viewport with fusion

3 participants