feat: upgrade to vtk.js 34.x #2398
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let's see tests passing or not, there seem to be some build errors though $ tsc --project ./tsconfig.json
src/cache/classes/Mesh.ts:61:15 - error TS2339: Property 'setInputConnection' does not exist on type 'Readonly<{}>'.
61 normals.setInputConnection(reader.getOutputPort());
~~~~~~~~~~~~~~~~~~
src/cache/classes/Mesh.ts:62:41 - error TS2339: Property 'getOutputPort' does not exist on type 'Readonly<{}>'.
62 mapper.setInputConnection(normals.getOutputPort());
~~~~~~~~~~~~~
src/RenderingEngine/renderPasses/sharpeningRenderPass.ts:19:21 - error TS2339: Property 'setDelegates' does not exist on type 'Readonly<{}>'.
19 convolutionPass.setDelegates([renderPass]);
~~~~~~~~~~~~
src/RenderingEngine/renderPasses/sharpeningRenderPass.ts:27:21 - error TS2339: Property 'setKernelDimension' does not exist on type 'Readonly<{}>'.
27 convolutionPass.setKernelDimension(3);
~~~~~~~~~~~~~~~~~~
src/RenderingEngine/renderPasses/sharpeningRenderPass.ts:28:21 - error TS2339: Property 'setKernel' does not exist on type 'Readonly<{}>'.
28 convolutionPass.setKernel([-k, -k, -k, -k, 1 + 8 * k, -k, -k, -k, -k]);
~~~~~~~~~also i'm not sure why we are removing preferSizeOverAccuracy? does that not work anymore in 34? |
…multi-input volumes - Added logic to determine the number of components based on valid inputs. - Updated the use of independent components based on volume properties for multi-component data.
|
I am not sure why the TestPattern tests are failing 
|
|
I will check |
|
can you fix the rest of issues? these mapper.setInputConnection(reader.getOutputPort()); |
|
@sedghi yes i can look at them if have you fixed the TestPattern tests |
|
it is super weird since we don't have much image mapper related custom loading, we just use the vtkImageMapper. |
|
@sedghi i don't see those errors on my machine, maybe if you push to see what ci says it will help |
|
@daker here is the ci for bun build |
|
@sedghi i might think it's an easy fix but i don't have bun installed, you just need to update vtk.js in the @cornerstonejs/tools package, the bun.lock uses 8102ca3#diff-bfd0ef82a01108fa1e836c2500b98b7de8a92bb1ae352a8efcbd9d6ffcaabd60R4421 
|
|
@daker I wasn't able to figure out the color, i posted to vtk forum to see https://discourse.vtk.org/t/color-images-not-rendering-after-upgrade-to-vtk-js-34-0-0/16104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily updates the dependency on
@kitware/vtk.jsto version34.13.2across multiple packages and refines rendering configuration handling in the core rendering engine. The most significant impact is improved compatibility with the latest VTK.js and more consistent usage of thepreferSizeOverAccuracyrendering option.Dependency Updates
@kitware/vtk.jsdependency to version34.13.2inpackages/core/package.json,packages/labelmap-interpolation/package.json, andpackages/polymorphic-segmentation/package.jsonfor improved compatibility and access to new features. [1] [2] [3]Rendering Configuration Improvements
getConfiguration().rendering.preferSizeOverAccuracyincreateVolumeActor.tsto set the rendering accuracy for volume actors, ensuring consistent behavior. [1] [2]preferSizeOverAccuracyincreateVolumeMapper.tsandStackViewport.ts, centralizing configuration logic and reducing redundant code. [1] [2]Internal API Consistency
vtkStreamingOpenGLTexture.jsAPI to accept parameters as an object instead of positional arguments, improving readability and maintainability.Minor Code Consistency
version.tsfor consistency.