Skip to content

Conversation

@sedghi
Copy link
Member

@sedghi sedghi commented Nov 1, 2025

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Note

Upgrade Rspack/core and related bindings/module-federation to 1.6-compatible versions; enable experiments.nativeWatcher in example runner configs; regenerate lockfiles.

  • Build/Tooling:
    • Upgrade @rspack/core to 1.6.0 and update related @rspack/binding* and @module-federation/* packages to compatible versions.
    • Regenerate bun.lock and yarn.lock with updated dependencies (including internal @cornerstonejs/* package version bumps).
  • Examples:
    • Add experiments.nativeWatcher: true to utils/ExampleRunner/template-config.js and utils/ExampleRunner/template-multiexample-config.js.

Written by Cursor Bugbot for commit d937c79. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings November 1, 2025 13:59
@sedghi
Copy link
Member Author

sedghi commented Nov 1, 2025

@jbocce for some reason i can't do bun i, can you double check if my yarn and bun files are correct thanks

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Rspack build tooling from version 1.2.8 to 1.6.0 and enables the nativeWatcher experiment configuration option in the webpack configuration templates used by the example runner.

Key changes:

  • Upgraded @rspack/core from 1.2.8 to 1.6.0 along with all related Rspack binding dependencies
  • Upgraded @module-federation packages from 0.8.4 to 0.21.2
  • Enabled nativeWatcher: true in the experiments configuration for both single and multi-example webpack templates

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
yarn.lock Updated lockfile with new versions of @rspack/core (1.6.0), @module-federation packages (0.21.2), and related dependencies including new WASM bindings
package.json Updated @rspack/core dependency from 1.2.8 to 1.6.0
utils/ExampleRunner/template-config.js Added nativeWatcher: true to experiments configuration
utils/ExampleRunner/template-multiexample-config.js Added nativeWatcher: true to experiments configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

experiments: {
asyncWebAssembly: true
asyncWebAssembly: true,
nativeWatcher: true
Copy link

Copilot AI Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Missing trailing comma after nativeWatcher: true. While not required by JavaScript syntax, adding a trailing comma would be consistent with the project's style as seen in other object properties (e.g., line 70 in externals) and makes future additions cleaner.

Suggested change
nativeWatcher: true
nativeWatcher: true,

Copilot uses AI. Check for mistakes.
@jbocce
Copy link
Collaborator

jbocce commented Nov 1, 2025

@jbocce for some reason i can't do bun i, can you double check if my yarn and bun files are correct thanks

You likely need to run yarn run install:update-lockfile and once you do that I can quickly look over your lockfiles.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

"packages/tools": {
"name": "@cornerstonejs/tools",
"version": "4.8.0",
"version": "4.8.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Peer Dependency Version Mismatch Across Packages

Several @cornerstonejs packages updated to 4.8.1, but their peerDependencies still point to 4.8.0. Since the peer dependency packages also updated to 4.8.1, this version mismatch will cause peer dependency warnings or resolution conflicts.

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbocce please check this

@sedghi sedghi merged commit c389653 into main Nov 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants