-
Notifications
You must be signed in to change notification settings - Fork 439
chore(version): update package versions and add nativeWatcher experiment #2439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jbocce for some reason i can't do bun i, can you double check if my yarn and bun files are correct thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Rspack build tooling from version 1.2.8 to 1.6.0 and enables the nativeWatcher experiment configuration option in the webpack configuration templates used by the example runner.
Key changes:
- Upgraded @rspack/core from 1.2.8 to 1.6.0 along with all related Rspack binding dependencies
- Upgraded @module-federation packages from 0.8.4 to 0.21.2
- Enabled
nativeWatcher: truein the experiments configuration for both single and multi-example webpack templates
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| yarn.lock | Updated lockfile with new versions of @rspack/core (1.6.0), @module-federation packages (0.21.2), and related dependencies including new WASM bindings |
| package.json | Updated @rspack/core dependency from 1.2.8 to 1.6.0 |
| utils/ExampleRunner/template-config.js | Added nativeWatcher: true to experiments configuration |
| utils/ExampleRunner/template-multiexample-config.js | Added nativeWatcher: true to experiments configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| experiments: { | ||
| asyncWebAssembly: true | ||
| asyncWebAssembly: true, | ||
| nativeWatcher: true |
Copilot
AI
Nov 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Missing trailing comma after nativeWatcher: true. While not required by JavaScript syntax, adding a trailing comma would be consistent with the project's style as seen in other object properties (e.g., line 70 in externals) and makes future additions cleaner.
| nativeWatcher: true | |
| nativeWatcher: true, |
You likely need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| "packages/tools": { | ||
| "name": "@cornerstonejs/tools", | ||
| "version": "4.8.0", | ||
| "version": "4.8.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbocce please check this
Context
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment
Note
Upgrade Rspack/core and related bindings/module-federation to 1.6-compatible versions; enable experiments.nativeWatcher in example runner configs; regenerate lockfiles.
@rspack/coreto1.6.0and update related@rspack/binding*and@module-federation/*packages to compatible versions.bun.lockandyarn.lockwith updated dependencies (including internal@cornerstonejs/*package version bumps).experiments.nativeWatcher: truetoutils/ExampleRunner/template-config.jsandutils/ExampleRunner/template-multiexample-config.js.Written by Cursor Bugbot for commit d937c79. This will update automatically on new commits. Configure here.