Fix Segment Opacity Update When Adjusting Fill in Segmentation Styles #2450
+277
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses the issue where, after clicking on segments and adjusting the segmentation's fill, the opacity of the clicked segments doesn't update as expected. The root cause was that the fillAlpha value was being applied at the per-segment level during highlighting, but the corresponding per-segment entry in the config was not being cleared afterward. As a result, the global-level opacity (fillAlpha) setting was not taking effect correctly.
Fixes: OHIF/Viewers#4977
Dependent PR : OHIF/Viewers#4978
Changes & Results
-
_removeStyleFromHigherLevels— Removes higher-level overrides before restoration.-
_applyStyleValueAtLevel— Reapplies captured style values at their original configuration level.-
_getCurrentValueForRestore— Determines current style value and its hierarchy level.-
_getViewportLevelValue, _getSegmentationLevelValue, _getGlobalLevelValue— Level-specific lookup helpers.Before
After
Testing
abhijith-trenser:fix/segmentation-fill-not-working-after-loading-seg-and-click-segmentsbranch with the cornerstone3D branchDevu-trenser:fix/seg-fill-not-working-after-segment-click.Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment