Upgrade alertmanager version to v0.28.0 #6590
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rajagopalanand @rapphil Can you help review this change? |
|
@SungJin1212 Can you please add changelog? |
SungJin1212
force-pushed
the
Upgrade-alertmanager-v0.28.0
branch
from
1228a89 to
48d8cfb
Compare
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Upgrade-alertmanager-v0.28.0
branch
from
48d8cfb to
6ce7ac3
Compare
yeya24
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Looks good. Better to wait for review from @rajagopalanand or @rapphil before merging
rapphil
reviewed
Feb 22, 2025
pkg/alertmanager/alertmanager.go
Outdated
| @@ -99,7 +103,7 @@ type Alertmanager struct { | |||
| persister *statePersister | |||
| nflog *nflog.Log | |||
| silences *silence.Silences | |||
| marker types.Marker | |||
| marker *types.MemMarker | |||
There was a problem hiding this comment.
Shouldn't we be relying on the interface here instead of the implementation? The
previous Marker interface was renamed to AlertMarker prometheus/alertmanager@d31a249
There was a problem hiding this comment.
thanks, I split it into two interfaces.
alertMarker types.AlertMarker
groupMarker types.GroupMarker
rapphil
reviewed
Feb 22, 2025
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Upgrade-alertmanager-v0.28.0
branch
from
7a1a905 to
650d43c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the Prometheus Alertmanager version to v0.28.0.
Notable changes:
The new integrations are added (msteamsv2, jira, and rocketchat)
It switches to use the
slog; we can use aGoKitLogToSlog.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]