Add metric and enhanced logging for query partial data #6676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Jung <[email protected]>
Signed-off-by: Justin Jung <[email protected]>
Signed-off-by: Justin Jung <[email protected]>
justinjung04
changed the title
Signed-off-by: Justin Jung <[email protected]>
Signed-off-by: Justin Jung <[email protected]>
justinjung04
force-pushed
the
partial-data
branch
from
2db2a3f to
36b6fcc
Compare
dosubot
bot
added
component/ring
type/observability
yeya24
approved these changes
Apr 3, 2025
wilguo
pushed a commit
to wilguo/cortex
that referenced
this pull request
Apr 10, 2025
…#6676) * add metric Signed-off-by: Justin Jung <[email protected]> * improve log to include failed instance address Signed-off-by: Justin Jung <[email protected]> * more tests Signed-off-by: Justin Jung <[email protected]> * changelog Signed-off-by: Justin Jung <[email protected]> * include all partial errors in log Signed-off-by: Justin Jung <[email protected]> --------- Signed-off-by: Justin Jung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Query partial data (#6526) was introduced such that queries to ingesters return 200 even when data from ingesters can be partial.
This is an improvement on top to add metric and enhanced logging to further debug why partial data was returned to the customers.
Which issue(s) this PR fixes:
n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]