Skip to content

Commit

Permalink
imp(apps): allow one sided fee middleware handshakes to complete (bac…
Browse files Browse the repository at this point in the history
…kport #6253) (#6260)

* imp(apps): allow one sided fee middleware handshakes to complete (#6253)

* imp: added counter version proposal to try step

* test: fixed tests

* test: tested removing fee middleware

* test: added ica onesided test

* add changelog

* imp: improved RemoveFeeMiddleware

* nit: damian

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
(cherry picked from commit 3b3ecc5)

# Conflicts:
#	CHANGELOG.md
#	modules/apps/27-interchain-accounts/host/keeper/handshake.go
#	modules/apps/29-fee/fee_test.go
#	modules/apps/29-fee/ibc_middleware.go
#	modules/apps/29-fee/transfer_test.go
#	modules/apps/transfer/ibc_module.go
#	modules/apps/transfer/ibc_module_test.go

* imp: iteration one

* imp: iteration two

* Update CHANGELOG.md

---------

Co-authored-by: srdtrk <[email protected]>
Co-authored-by: srdtrk <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
  • Loading branch information
4 people authored May 7, 2024
1 parent fea2507 commit 3ef2a97
Show file tree
Hide file tree
Showing 157 changed files with 117 additions and 57,416 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ Ref: https://keepachangelog.com/en/1.0.0/
### Improvements

* (apps/27-interchain-accounts) [\#6147](https://github.com/cosmos/ibc-go/pull/6147) Emit an event signalling that the host submodule is disabled.
* (testing) [\#6180](https://github.com/cosmos/ibc-go/pull/6180) Add version to tm abci headers in ibctesting.
* (testing) [\#6180](https://github.com/cosmos/ibc-go/pull/6180) Add version to tm abci headers in ibctesting.
* (apps/27-interchain-accounts, apps/tranfer, apps/29-fee) [\#6253](https://github.com/cosmos/ibc-go/pull/6253) Allow channel handshake to succeed if fee middleware is wired up on one side, but not the other.

### Features

Expand Down
Loading

0 comments on commit 3ef2a97

Please sign in to comment.