This repository was archived by the owner on Apr 10, 2026. It is now read-only.
Remove conditional hashing in ethermint PrivKey.Sign method#1562
Open
GarmashAlex wants to merge 1 commit into
Open
Remove conditional hashing in ethermint PrivKey.Sign method#1562GarmashAlex wants to merge 1 commit into
GarmashAlex wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the conditional Keccak256 hashing in the PrivKey.Sign method
as indicated by the TODO comment. The method now expects properly formatted digest
bytes to be provided by the caller without applying any additional processing.
This change simplifies the API and makes the behavior more predictable and direct
by removing the automatic fallback to hashing. All tests continue to pass after
this modification, confirming that existing functionality is preserved.