Add deltaSrc to replication protocol #2242
Open
+35
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage Results:
|
borrrden
reviewed
Feb 26, 2025
| @@ -169,7 +169,7 @@ _(optional)_ + | |||
| `versioning`: `rev-trees` (default) or `version-vectors` -- see the <<revIDs>> section. + | |||
| _other properties_: Named parameters for the filter function | |||
| _(optional)_ + | |||
| `sendReplacementRevs`: Boolean indicating whether the passive peer (pusher) should send replacement revs rather than NoRev when the body of a requested rev is unavailable and a newer revision is available. _(optional)_+ | |||
| `sendReplacementRevs`: Boolean indicating whether the passive peer (pusher) should send replacement revs rather than NoRev when the body of a requested rev is unavailable and a newer revision is available. _(optional)_ + | |||
There was a problem hiding this comment.
It's not random, it is required to put this text on a newline. https://docs.asciidoctor.org/asciidoc/latest/blocks/hard-line-breaks/
Without this, the next line would be on the same line.
borrrden
reviewed
Feb 26, 2025
| while processing the `rev` message, in which case it MUST NOT send the | ||
| `rev`'s response until it's received responses to the `getattach` | ||
| ``rev``'s response until it's received responses to the `getAttachment` |
There was a problem hiding this comment.
Why the need for double backtick?
There was a problem hiding this comment.
Otherwise, this whole section is indented.
|
I used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit fixes sublists being eaten, caught by
asciidoctorand by eye.+was present.Substantive part of the changes was adding
deltaSrcproperty to the definition.