Skip to content

Commit

Permalink
chore(tests): fix flakiness issue (#4905)
Browse files Browse the repository at this point in the history
https://coveord.atlassian.net/browse/KIT-3882

This fixes the following issue:

```
Warning: vkCreateInstance: Found no drivers!
Warning: vkCreateInstance failed with VK_ERROR_INCOMPATIBLE_DRIVER
    at CheckVkSuccessImpl (../../third_party/dawn/src/dawn/native/vulkan/VulkanError.cpp:88)
    at CreateVkInstance (../../third_party/dawn/src/dawn/native/vulkan/BackendVk.cpp:458)
    at Initialize (../../third_party/dawn/src/dawn/native/vulkan/BackendVk.cpp:344)
    at Create (../../third_party/dawn/src/dawn/native/vulkan/BackendVk.cpp:266)
    at operator() (../../third_party/dawn/src/dawn/native/vulkan/BackendVk.cpp:521)
```

It is caused by Cypress overreacting to benign warnings (see
cypress-io/cypress#29085 (comment))

This faulty behavior has been fixed in Cypress
[13.7.3](https://docs.cypress.io/app/references/changelog#13-7-3)

Upgrading to this version of Cypress caused a set of Quantic tests to
fail (see
#4905 (comment)), which
has been addressed in [this
commit](fb37468).

---------

Co-authored-by: Alex Prudhomme <[email protected]>
Co-authored-by: mmitiche <[email protected]>
  • Loading branch information
3 people authored Jan 29, 2025
1 parent bf6bed4 commit ab7f0d5
Show file tree
Hide file tree
Showing 10 changed files with 3,236 additions and 2,610 deletions.
5,800 changes: 3,211 additions & 2,589 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/atomic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
"@whitespace/storybook-addon-html": "6.1.1",
"autoprefixer": "10.4.20",
"axe-core": "4.10.2",
"cypress": "13.6.6",
"cypress": "13.7.3",
"cypress-axe": "1.5.0",
"cypress-repeat": "2.3.8",
"cypress-split": "1.5.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,18 @@ function timeframeFacetActions(selector: TimeframeFacetSelector) {
collapse: () => selector.collapseButton().click(),
expand: () => selector.expandButton().click(),

typeStartDate: (dateString: string) =>
selector.startInput().clear().type(dateString),
typeEndDate: (dateString: string) =>
selector.endInput().clear().type(dateString),

typeStartDate: (dateString: string) => {
selector.startInput().clear().type(dateString);
selector.startInput().blur();
},
typeEndDate: (dateString: string) => {
selector.endInput().clear().type(dateString);
selector.endInput().blur();
},
applyRange: (start: string, end: string) => {
selector.startInput().clear().type(start);
selector.endInput().clear().type(end);
selector.endInput().blur();
selector.form().submit();
},

Expand Down
6 changes: 3 additions & 3 deletions packages/quantic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@
"@coveo/bueno": "1.0.7",
"@coveo/headless": "3.14.0",
"dompurify": "3.2.3",
"marked": "12.0.2",
"fs-extra": "11.2.0"
"fs-extra": "11.2.0",
"marked": "12.0.2"
},
"engines": {
"node": "^20.9.0 || ^22.11.0"
Expand All @@ -75,7 +75,7 @@
"@types/wait-on": "5.3.4",
"chalk": "4.1.2",
"change-case": "4.1.2",
"cypress": "13.6.6",
"cypress": "13.7.3",
"cypress-real-events": "1.13.0",
"cypress-repeat": "2.3.8",
"dotenv": "16.4.7",
Expand Down
2 changes: 1 addition & 1 deletion packages/samples/atomic-next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@types/node": "22.10.6",
"@types/react": "18.3.3",
"@types/react-dom": "18.3.0",
"cypress": "13.6.6",
"cypress": "13.7.3",
"cypress-repeat": "2.3.8",
"ncp": "2.0.0",
"typescript": "5.5.4"
Expand Down
2 changes: 1 addition & 1 deletion packages/samples/headless-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"devDependencies": {
"@typescript-eslint/eslint-plugin": "8.7.0",
"@vitejs/plugin-react": "4.3.2",
"cypress": "13.6.6",
"cypress": "13.7.3",
"cypress-repeat": "2.3.8",
"gts": "5.3.1",
"vite": "5.4.11",
Expand Down
8 changes: 4 additions & 4 deletions packages/samples/headless-ssr/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
"@types/node": "22.10.6",
"@types/react": "18.3.3",
"@types/react-dom": "18.3.0",
"cypress": "13.7.3",
"cypress-repeat": "2.3.8",
"cypress-web-vitals": "4.1.2",
"eslint": "8.57.1",
"eslint-config-react-app": "7.0.1",
"typescript": "5.5.4",
"cypress": "13.6.6",
"cypress-repeat": "2.3.8",
"cypress-web-vitals": "4.1.2"
"typescript": "5.5.4"
}
}
2 changes: 1 addition & 1 deletion packages/samples/iife/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"react-dom": "18.3.1"
},
"devDependencies": {
"cypress": "13.6.6",
"cypress": "13.7.3",
"cypress-repeat": "2.3.8",
"ncp": "2.0.0",
"resolve": "1.22.10",
Expand Down
2 changes: 1 addition & 1 deletion packages/samples/stencil/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"devDependencies": {
"@typescript-eslint/eslint-plugin": "7.18.0",
"cypress": "13.6.6",
"cypress": "13.7.3",
"cypress-repeat": "2.3.8",
"gts": "5.3.1",
"rollup-plugin-html": "0.2.1"
Expand Down
8 changes: 4 additions & 4 deletions packages/samples/vuejs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@
},
"devDependencies": {
"@vitejs/plugin-vue": "5.2.1",
"typescript": "5.5.4",
"vite": "5.4.11",
"cypress": "13.6.6",
"cypress": "13.7.3",
"cypress-repeat": "2.3.8",
"ncp": "2.0.0"
"ncp": "2.0.0",
"typescript": "5.5.4",
"vite": "5.4.11"
}
}

0 comments on commit ab7f0d5

Please sign in to comment.