-
Notifications
You must be signed in to change notification settings - Fork 3
chore: remove Python 3.8 support as it is EOL #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThis pull request updates the Python version configuration in two places. In the GitHub Actions workflow file, the version matrix used for testing is narrowed by removing Python 3.8 from the list. In the project configuration file (pyproject.toml), the minimum required Python version is raised from 3.8 to 3.9, and the Python 3.8 classifier is removed. No changes were made to public API declarations. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant Test as Test Job
Dev->>GH: Push commit with updated configs
GH->>Test: Trigger test job with new Python matrix (3.9 to 3.14)
Test->>Test: Run tests across specified Python versions
Test-->>GH: Return test results
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 3 3
Lines 77 77
=======================================
Hits 66 66
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Remove Python 3.8 support as it is EOL. btw, pre-commit also does not support Python 3.8 anymore.
https://github.com/pre-commit/pre-commit/blob/aa48766b888990e7b118d12cf757109d96e65a7e/setup.cfg#L27
Summary by CodeRabbit
These updates adjust the automated testing and compatibility settings to align with current Python standards, ensuring a modern and consistent development workflow.