Skip to content

chore: remove Python 3.8 support as it is EOL #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

shenxianpeng
Copy link
Collaborator

@shenxianpeng shenxianpeng commented Mar 25, 2025

Remove Python 3.8 support as it is EOL. btw, pre-commit also does not support Python 3.8 anymore.

https://github.com/pre-commit/pre-commit/blob/aa48766b888990e7b118d12cf757109d96e65a7e/setup.cfg#L27

Summary by CodeRabbit

These updates adjust the automated testing and compatibility settings to align with current Python standards, ensuring a modern and consistent development workflow.

  • Tests
    • Refined automated testing to focus on supported Python versions for improved validation.
  • Chores
    • Updated project compatibility to require a minimum Python version of 3.9, dropping older version support.

@shenxianpeng shenxianpeng added the enhancement New feature or request label Mar 25, 2025
Copy link

coderabbitai bot commented Mar 25, 2025

Walkthrough

This pull request updates the Python version configuration in two places. In the GitHub Actions workflow file, the version matrix used for testing is narrowed by removing Python 3.8 from the list. In the project configuration file (pyproject.toml), the minimum required Python version is raised from 3.8 to 3.9, and the Python 3.8 classifier is removed. No changes were made to public API declarations.

Changes

File(s) Change Summary
.github/workflows/test.yml, pyproject.toml Updated Python version configurations to remove support for Python 3.8. The workflow’s version matrix omits 3.8, and pyproject.toml now requires >=3.9.

Sequence Diagram(s)

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub Actions
    participant Test as Test Job
    Dev->>GH: Push commit with updated configs
    GH->>Test: Trigger test job with new Python matrix (3.9 to 3.14)
    Test->>Test: Run tests across specified Python versions
    Test-->>GH: Return test results
Loading

Possibly related PRs

Poem

Hopping along the code-filled lane,
I bid farewell to Python 3.8, plain.
New versions now take the stage,
A streamlined test in every gauge.
With joyful paws, I type and play—
A rabbit’s cheer for a brighter day!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b17b01 and a786df5.

📒 Files selected for processing (2)
  • .github/workflows/test.yml (1 hunks)
  • pyproject.toml (1 hunks)
🔇 Additional comments (3)
.github/workflows/test.yml (1)

15-15: CI Matrix Update: Python 3.8 Removal Verified
The updated python-version matrix now correctly excludes Python 3.8, retaining only the supported versions from 3.9 through 3.14.0-alpha.2. This fully aligns with the PR objective to remove Python 3.8 support.

pyproject.toml (2)

5-5: Update: Minimum Python Requirement Raised
Changing requires-python from ">=3.8" to ">=3.9" correctly reflects the removal of Python 3.8 support. This step guarantees that users are notified of the updated minimum version requirement.


16-31: Metadata Cleanup: Removal of Python 3.8 Classifier
The removal of the "Programming Language :: Python :: 3.8" classifier from the classifiers section is consistent with the updated Python version requirement. This clean-up ensures clarity in project metadata and aligns with the overall intent of the PR.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.71%. Comparing base (9b17b01) to head (a786df5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files           3        3           
  Lines          77       77           
=======================================
  Hits           66       66           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shenxianpeng shenxianpeng merged commit 91d34a8 into main Mar 25, 2025
15 checks passed
@shenxianpeng shenxianpeng deleted the drop-support-py3.8 branch March 25, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant