Avoid synchronization on GetQueues #116
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Klock <[email protected]>
Signed-off-by: Laurent Klock <[email protected]>
Finalized AbstractFrontierService modification (removal of synchronizations on queues) Signed-off-by: Laurent Klock <[email protected]>
|
Thanks @klockla, sounds good |
Signed-off-by: Laurent Klock <[email protected]>
Signed-off-by: Laurent Klock <[email protected]>
Signed-off-by: Laurent Klock <[email protected]>
…erence to the order entry in the value map (huge boost on remove operation by avoiding searching the matching key) Signed-off-by: Laurent Klock <[email protected]>
Signed-off-by: Laurent Klock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to avoid the synchronization on the internal queue map.
The synchronized(getQueues()) call causes contention during long queue traversals which are very likely to occur during calls to countURLs & ListURLs.
This change is based on the ConcurrentOrdereredMap class which uses StampLock to provide fine
fine-grained locking over the concurrent map.
(alternative in ConcurrentLinkedHashMap based on ReentrantLock, need to compare under stress tests)
Signed-off-by: Laurent Klock [email protected]