Skip to content

Feature/manage instance service #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ZeroPointEnergy
Copy link

This is an optional setting to manage the db2 instances service with systemd. It is disabled by default to retain backward compatibility to previous configurations.

enable => true,
subscribe => [
Exec['db2_systemd_daemon_reload'],
Db2_instance[$instance_user],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggests that the service needs to be restarted after adding an instance, dcs, catalog or database.... Is this really the case?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so, but now that you ask I will check this with the database specialists so we get the behaviour right.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZeroPointEnergy any update on this? Id like to merge your change but we need to clarify and update the pr if necessary. Thanks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crayfishx sorry for the delay, we where able to get some more information on this. The DB2 specialists recommend that the instance does not get started when new nodes, databases and dcs are catalogued, but that the instance has to be running already.

Also another question came up about if the service needs to be managed at all or if only the service file is required. I will close the current PR if that is ok and create a new one once this is sorted.

@ZeroPointEnergy
Copy link
Author

Ok, never mind, I just fixed it in the current PR. I also added the possibility to set the service ensure and enable parameters per instance. The service is enabled by default to make sure it starts up on server reboot, but puppet does not try to start it by default (so it does not interfere with maintenance etc).

Please let me know if there are additional concerns.

@ZeroPointEnergy
Copy link
Author

@crayfishx is it possible that we can get this PR merged and a new release? Let me know if there is anything missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants