Additional groups #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User can define supplementary groups for instance and fenced users. Multiple groups can be defined as an array.
…they are defined as authoritative
|
Looks like the test for puppet 3 are failing becuase I used an iterator. Is puppet 3 support still desired? Could probably relocate the the collector into a define and create instances with the groups array to get the same effect. But that would be a bit ugly compared to the iterator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with the additional groups when the group itself is already defined somewhere else, for example with the accounts module and the member list is authoritative (auth_membership => true). In this case the user resource and the group resource will fight over the members list.
The user resource will append the user to the list and in the next run the group resource will remove it again to make sure the list only contains the members specified.
This PR extends the PR #27 with some resource collectors that make sure the users are appended to the group resources if they exist.