Build strategy based on containers with cache #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbraad
reviewed
May 10, 2024
Makefile
Outdated
| # Build the container cache image | ||
| .PHONY: build-cache | ||
| build-cache: | ||
| ${CONTAINER_MANAGER} build -t ${IMG_CACHE} -f oci/Containerfile.cache . |
There was a problem hiding this comment.
Who maintains the lifecycle of this cache?
There was a problem hiding this comment.
the idea would be self managed on every merge to main a gh action will build the image and push it
adrianriobo
force-pushed
the
fix-213
branch
3 times, most recently
from
b621a39 to
db71ade
Compare
adrianriobo
changed the title
adrianriobo
changed the title
|
@benoitf added you here as per our discussions about a way to move the cache into a building strategy based on Containerfiles |
|
This depends on #222 |
Signed-off-by: Adrian Riobo Lorenzo <[email protected]>
benoitf
reviewed
May 29, 2024
.github/workflows/release.yaml
Outdated
| @@ -24,7 +24,7 @@ on: | |||
|
|
|||
| jobs: | |||
| release: | |||
| runs-on: ubuntu-latest | |||
| runs-on: ubuntu-22.04 | |||
benoitf
approved these changes
May 29, 2024
Signed-off-by: Adrian Riobo Lorenzo <[email protected]>
benoitf
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #213