Problem: walletconnect 2.0 not supporting metamask android (fix #462) #464
+1,430
−941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
==========================================
+ Coverage 19.02% 19.03% +0.01%
==========================================
Files 24 24
Lines 3880 3877 -3
==========================================
Hits 738 738
+ Misses 3142 3139 -3 ☔ View full report in Codecov by Sentry. |
|
fixing audit issue need to upgrade ethers-rs to 2.0.11 |
leejw51crypto
force-pushed
the
feature/462
branch
from
b58eb0e to
70b2303
Compare
leejw51crypto
force-pushed
the
feature/462
branch
from
1f1a219 to
2418453
Compare
|
checking ci |
|
fixing WalletConnectRust security issue |
Solution: fix send transaction tidy up send tx refactor remove comment tidy up remove debug print rename changelog change version update Cargo.lock update Cargo.lock fix fmt fix clippy update cargo.lock add system config fix mac build update defi-wallet-core update cargo.lock fix audit issue tidy up TOPIC tidy up from,to tidy up comment
leejw51crypto
force-pushed
the
feature/462
branch
from
d3f027c to
37893a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: fix send transaction